Swap dummy perf testing projects for a real one #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed integration test is the exact thing we should look at when we go to fix the tests this cycle 😢 |
leahwicz
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To test PR#6302 I used dummy projects which are currently merged. This PR ONLY swaps out those target projects. There are no code changes here. There is only one target project now and it has 2000 model files.
As a best practice, performance testing targets are generally checked in instead of generated. Even though this example is from a generated project, to show without a doubt that the generation does not change between runs, we simply check in the generated files. In the future we could consider separating out our performance work from the main repository, however as of this change, these files only add an additional ~6k to our codebase which will have a negligible effect on our contributors.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.